[ https://issues.apache.org/jira/browse/FLINK-26892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17513791#comment-17513791 ]
Biao Geng edited comment on FLINK-26892 at 3/29/22, 4:10 AM: ------------------------------------------------------------- In our current code, IIUC, validation error should only happen when users apply a changed yaml file with wrong configs, right? It seems that no bad things will happen: the triggered {{FlinkDeploymentController# reconcile()}} directly returns with no further reschedule. The operator keeps using previous configs and {{reconcile()}} logic(so, the {{reconcile()}} will be triggered after 15 secs and the state of the JM/job can be updated). Is anything I missed or strong point to trigger a new observe() once the yaml file is applied? was (Author: bgeng777): In our current code, IIUC, validation error should only happen when users apply a changed yaml file with wrong configs, right? It seems that no bad things will happen: the triggered {{FlinkDeploymentController# reconcile()}} directly returns with no further reschedule. The operator keeps using previous configs and {{reconcile() }} logic(so, the {{reconcile()}} will be triggered after 15 secs and the state of the JM/job can be updated). Is anything I missed or strong point to trigger a new observe() once the yaml file is applied? > Observe current status before validating CR changes > --------------------------------------------------- > > Key: FLINK-26892 > URL: https://issues.apache.org/jira/browse/FLINK-26892 > Project: Flink > Issue Type: Improvement > Components: Kubernetes Operator > Reporter: Gyula Fora > Priority: Major > Fix For: kubernetes-operator-1.0.0 > > > Currently validation is the first step in the controller loop which means > that when there is a validation error we fail to observe the status of > currently running deployments. > We should change the order of operations and observe before validation. > Furthermore observe should use the previous configuration not the one after > the CR change. -- This message was sent by Atlassian Jira (v8.20.1#820001)