dawidwys commented on a change in pull request #19281:
URL: https://github.com/apache/flink/pull/19281#discussion_r838562183
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/StopWithSavepoint.java
##########
@@ -146,7 +147,16 @@ public JobStatus getJobStatus() {
@Override
void onFailure(Throwable cause) {
operationFailureCause = cause;
- FailureResultUtil.restartOrFail(context.howToHandleFailure(cause),
context, this);
+ if (savepoint == null) {
+ FailureResultUtil.restartOrFail(context.howToHandleFailure(cause),
context, this);
+ } else {
+ // savepoint has been create successfully, but the job failed
while committing side
+ // effects
+ final StopWithSavepointStoppingException ex =
+ new StopWithSavepointStoppingException(savepoint,
this.getJobId());
Review comment:
Good point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
