zentol commented on a change in pull request #19263:
URL: https://github.com/apache/flink/pull/19263#discussion_r838805255
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/MetricOptions.java
##########
@@ -117,8 +119,88 @@
.withDescription(
"The set of variables that should be excluded for
the reporter named <name>. Only applicable to tag-based reporters (e.g.,
PRometheus, InfluxDB).");
+ private static final Description.DescriptionBuilder addFilterDescription(
+ Description.DescriptionBuilder description) {
+ return description
+ .text("Filters are specified as a list, with each filter
following this format:")
+ .linebreak()
+ .text("%s",
code("<scope>[:<name>[;<name#N>][:type[;type#N]]]"))
Review comment:
It's up to the user so I don't see the harm.
Personally I don't why
`"*.job.task.operator:numRecords*;debloatedBufferSize;mailboxLatency*:meter;gauge"`
is in any way less maintainable then
`"*.job.task.operator:numRecords*:meter;gauge";"*.job.task.operator:debloatedBufferSize:meter;gauge";"*.job.task.operator:mailboxLatency*:meter;gauge"`
Additionally, if we ever add support for proper yaml parsing then the ideal
solution would likely be the following, which is closer to the current
"powerful" option.
```
- filter:
scope: *.job.task.operator:numRecords*
names:
- numRecords*
- debloatedBufferSize
- mailboxLatency*
types:
- meter
- gauge
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
