JingsongLi commented on a change in pull request #69:
URL: https://github.com/apache/flink-table-store/pull/69#discussion_r840303084
##########
File path:
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/TableStoreSource.java
##########
@@ -159,14 +158,12 @@ public String asSummaryString() {
@Override
public Result applyFilters(List<ResolvedExpression> filters) {
- if (tableStore.partitioned()) {
+ if (logStoreTableFactory == null && tableStore.partitioned()) {
classifyFilters(filters);
} else {
fieldFilters = filters;
}
- return Result.of(
- new ArrayList<>(filters),
- fieldFilters == null ? Collections.emptyList() : fieldFilters);
+ return Result.of(new ArrayList<>(filters), fieldFilters);
Review comment:
I think it is better to here: `isStreaming && logStoreTableFactory !=
null ? filters : fieldFilters`.
- First, I think you lack isStreaming. `logStoreTableFactory` always exists
when log.system=kafka.
- Second, Even if there is log system, the case of hybrid needs partition
filter to filter filestore a large amount of data, which is very important.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
