Thesharing commented on pull request #19275:
URL: https://github.com/apache/flink/pull/19275#issuecomment-1085628342


   > For the HistoryServer, that's not the case. It will try to trigger the 
archiving again but would probably find a the ExecutionGraph already being 
archived for that job. This will result in a failure, i.e. the archiving is not 
idempotent which is actually should be. I created 
[FLINK-26976](https://issues.apache.org/jira/browse/FLINK-26976) to cover this.
   
   Thank you for your explanation, Matthias! I'm going to fix my pull request 
to make sure archiving is finished before triggering the cleanup.
   
   For FLINK-26976, changing 
org.apache.flink.runtime.history.FsJobArchivist#archiveJob from
   
   ```java
   OutputStream out = fs.create(path, FileSystem.WriteMode.NO_OVERWRITE);
   ```
   to
   ```java
   OutputStream out = fs.create(path, FileSystem.WriteMode.OVERWRITE);
   ```
   could solve the problem. Am I right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to