imaffe commented on a change in pull request #18816:
URL: https://github.com/apache/flink/pull/18816#discussion_r840379481
##########
File path:
flink-metrics/flink-metrics-core/src/main/java/org/apache/flink/metrics/groups/UnregisteredMetricsGroup.java
##########
@@ -178,4 +182,35 @@ public T getValue() {
return null;
}
}
+
+ private static class UnregisteredSinkWriterMetricGroup extends
UnregisteredMetricsGroup
Review comment:
Because I didn't find a good way to mock SinkWriterMetricGroup, and I
saw there are other UnregisterdXXXMetricGroup() used in tests, so I decided to
create one for sink.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
