syhily commented on a change in pull request #19285:
URL: https://github.com/apache/flink/pull/19285#discussion_r840536795
##########
File path:
flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/common/config/PulsarClientFactory.java
##########
@@ -200,15 +200,17 @@ private static Authentication
createAuthentication(PulsarConfiguration configura
String authParamsString =
configuration.get(PULSAR_AUTH_PARAMS);
return sneakyClient(
() ->
AuthenticationFactory.create(authPluginClassName, authParamsString));
- } else if (configuration.contains(PULSAR_AUTH_PARAM_MAP)) {
- Map<String, String> paramsMap =
configuration.get(PULSAR_AUTH_PARAM_MAP);
+ } else {
+ Map<String, String> paramsMap =
configuration.getProperties(PULSAR_AUTH_PARAM_MAP);
+ if (paramsMap.isEmpty()) {
Review comment:
Nope, `PulsarConfiguration#getProperties` will return empty map instead
of `null`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
