weibozhao commented on a change in pull request #56:
URL: https://github.com/apache/flink-ml/pull/56#discussion_r840992626
##########
File path:
flink-ml-lib/src/main/java/org/apache/flink/ml/common/param/HasHandleInvalid.java
##########
@@ -37,13 +37,14 @@
public interface HasHandleInvalid<T> extends WithParams<T> {
String ERROR_INVALID = "error";
String SKIP_INVALID = "skip";
+ String KEEP_INVALID = "keep";
Review comment:
I get your idea. I think it's better defining this parameter in the
VectorAssemblerParams, for keep has no meaning in OnehotEncoder fit and
transform.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
