YuriGusev commented on a change in pull request #18518: URL: https://github.com/apache/flink/pull/18518#discussion_r841057538
########## File path: flink-connectors/flink-connector-dynamodb/src/main/java/org/apache/flink/streaming/connectors/dynamodb/sink/TableRequestsContainer.java ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.streaming.connectors.dynamodb.sink; + +import org.apache.flink.streaming.connectors.dynamodb.config.DynamoDbTablesConfig; +import org.apache.flink.streaming.connectors.dynamodb.sink.key.PrimaryKey; + +import org.apache.flink.shaded.guava30.com.google.common.collect.ImmutableList; + +import software.amazon.awssdk.services.dynamodb.model.WriteRequest; + +import java.util.HashMap; +import java.util.LinkedHashMap; +import java.util.List; +import java.util.Map; + +/** + * Container to accumulate requests in batches per table. De-duplicates batch request entities as + * per PrimaryKey definition. DynamoDB Batch API rejects the whole batch request if the request + * contains at least two items with identical hash and range keys (which essentially is two put + * operations). + */ +class TableRequestsContainer { + + private final DynamoDbTablesConfig tablesConfig; + private final LinkedHashMap<String, Map<PrimaryKey, WriteRequest>> container; Review comment: Yes, strange, probably got lost on previous re-base. It is fixed now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
