alpreu commented on code in PR #19302:
URL: https://github.com/apache/flink/pull/19302#discussion_r842747667
##########
flink-connectors/flink-connector-elasticsearch-base/src/test/java/org/apache/flink/streaming/connectors/elasticsearch/table/IndexGeneratorFactoryTest.java:
##########
@@ -193,12 +202,26 @@ public void testDynamicIndexFromSystemTime() {
}
@Test
- public void testDynamicIndexDefaultFormatTimestampWithLocalTimeZone() {
+ public void testDynamicIndexDefaultFormatTimestampWithLocalTimeZoneUTC() {
+ assumeThat(ZoneId.systemDefault(), is(ZoneId.of("UTC")));
Review Comment:
The tests under `...streaming.connectors.elasticsearch` (for the old
SinkFunction based connector) are still using Junit 4. I could port them but
not sure if we should do that with tests that we want to remove soon anyway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
