fapaul commented on code in PR #19364:
URL: https://github.com/apache/flink/pull/19364#discussion_r843608467
##########
flink-connectors/flink-sql-connector-hive-2.3.9/pom.xml:
##########
@@ -30,8 +30,8 @@ under the License.
<relativePath>..</relativePath>
</parent>
-
<artifactId>flink-sql-connector-hive-2.3.6_${scala.binary.version}</artifactId>
- <name>Flink : Connectors : SQL : Hive 2.3.6</name>
+
<artifactId>flink-sql-connector-hive-2.3.9_${scala.binary.version}</artifactId>
Review Comment:
Renaming the module makes backporting difficult. I guess we only do it for
1.16?
##########
flink-connectors/flink-connector-hive/pom.xml:
##########
@@ -1027,15 +1027,15 @@ under the License.
<profiles>
<!-- Activate these profiles with -Phive-x.x.x to build and
test against different Hive versions -->
<profile>
- <id>hive-2.3.6</id>
+ <id>hive-2.3.9</id>
<properties>
- <hive.version>2.3.6</hive.version>
+ <hive.version>2.3.9</hive.version>
</properties>
<dependencies>
<dependency>
<groupId>org.apache.orc</groupId>
<artifactId>orc-core</artifactId>
-
<version>${hive-2.3.6-orc-version}</version>
+
<version>${hive-2.3.9-orc-version}</version>
Review Comment:
This complete profile seems to be broken. I neither see
`${hive-2.3.6-orc-version}` defined somewhere nor `${hive-2.3.9-orc-version}`.
Do I miss something here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
