snuyanzin commented on code in PR #18604:
URL: https://github.com/apache/flink/pull/18604#discussion_r843623713
##########
flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/psql/PostgresTypeMapper.java:
##########
@@ -49,6 +49,8 @@
// float <=> float8
// boolean <=> bool
// decimal <=> numeric
+ private static final String PG_SMALLSERIAL = "smallserial";
Review Comment:
In fact a test for `smallserial` is already present at
https://github.com/apache/flink/blob/99c0438253efaf0a9626a807ce2b882402a367d1/flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/catalog/PostgresCatalogTestBase.java#L360
before pgjdbc 42.2.17 `smallserial` was erroneously handled as `int2` and
test passed. In 42.2.17 it was fixed and this is the reason it starts failing.
Probably it makes sense to add test for `_smallserial`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
