curcur commented on PR #19331: URL: https://github.com/apache/flink/pull/19331#issuecomment-1091473226
> Thanks for the review @curcur, regarding > > > I am not fine with RestoreMode DEFAULT = NO_CLAIM and passed in EmbeddedCompletedCheckpointStore, StandaloneCompletedCheckpointStore, CheckpointResourcesCleanupRunner, EmbeddedHaServicesWithLeadershipControl. > > I've updated `EmbeddedHaServicesWithLeadershipControl` to use the `RestoreMode` from job settings. Other cases are test-only or specific to cleanup, where the restore mode is not applicable. > > > assuming all checkpoints belong to the same job, and non-referenced are subsumed as normal > > I think this depends on [#19331 (comment)](https://github.com/apache/flink/pull/19331#discussion_r844665419) Who will clean-up the checkpoints if JM failover, and with no-claim mode? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
