pnowojski commented on code in PR #23:
URL: https://github.com/apache/flink-benchmarks/pull/23#discussion_r845101917


##########
src/main/java/org/apache/flink/state/benchmark/RocksdbStateBackendRescalingBenchmarkExecutor.java:
##########
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.flink.state.benchmark;
+
+import org.apache.flink.api.common.JobID;
+import org.apache.flink.config.ConfigUtil;
+import org.apache.flink.config.StateBenchmarkOptions;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.contrib.streaming.state.EmbeddedRocksDBStateBackend;
+import 
org.apache.flink.contrib.streaming.state.benchmark.RescalingBenchmarkBuilder;
+import org.apache.flink.runtime.state.storage.FileSystemCheckpointStorage;
+
+import org.openjdk.jmh.annotations.*;
+import org.openjdk.jmh.runner.RunnerException;
+
+import java.io.IOException;
+
+import static java.util.concurrent.TimeUnit.MILLISECONDS;
+import static org.openjdk.jmh.annotations.Mode.AverageTime;
+
+@OutputTimeUnit(MILLISECONDS)
+@BenchmarkMode(AverageTime)
+@Warmup(iterations = 3)
+public class RocksdbStateBackendRescalingBenchmarkExecutor extends 
RescalingBenchmarkBase {
+    // numberOfKeys = 10_000_000, keyLen = 96, valueLen = 128, state size ~= 
2.2GB
+    private final int numberOfKeys = 10_000_000;
+    private final int keyLen = 96;
+
+    public static void main(String[] args) throws RunnerException {
+        runBenchmark(RocksdbStateBackendRescalingBenchmarkExecutor.class);
+    }
+
+    @Setup(Level.Trial)
+    public void setUp() throws Exception {
+        EmbeddedRocksDBStateBackend stateBackend = new 
EmbeddedRocksDBStateBackend(true);
+        Configuration benchMarkConfig = ConfigUtil.loadBenchMarkConf();
+        String stateDataDirPath = 
benchMarkConfig.getString(StateBenchmarkOptions.STATE_DATA_DIR);
+        benchmark =
+                new RescalingBenchmarkBuilder<byte[]>()
+                        .setMaxParallelism(128)
+                        
.setParallelismBefore(rescaleType.getParallelismBefore())
+                        .setParallelismAfter(rescaleType.getParallelismAfter())
+                        .setManagedMemorySize(512 * 1024 * 1024)
+                        .setCheckpointStorageAccess(
+                                new FileSystemCheckpointStorage("file://" + 
stateDataDirPath)
+                                        .createCheckpointStorage(new JobID()))
+                        .setStateBackend(stateBackend)
+                        .setStreamRecordGenerator(new 
ByteArrayRecordGenerator(numberOfKeys, keyLen))
+                        
.setStateProcessFunctionSupplier(TestKeyedFunction::new)
+                        .build();
+        benchmark.setUp();
+    }
+
+    @Setup(Level.Iteration)
+    public void setUpPerInvocation() throws Exception {
+        benchmark.prepareStateForOperator(rescaleType.getSubtaskIndex());
+    }
+
+    @TearDown(Level.Trial)
+    public void tearDown() throws IOException {
+        benchmark.tearDown();
+    }
+
+    @Benchmark
+    public void rescale() throws Exception {

Review Comment:
   One more thing, this method name is not unique:
   
   https://github.com/apache/flink-benchmarks#naming-convention
   
   rename to `rescaleHeap` and `rescaleRocksDB`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to