slinkydeveloper commented on code in PR #18386:
URL: https://github.com/apache/flink/pull/18386#discussion_r845819045
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/api/TableEnvironmentTest.scala:
##########
@@ -717,21 +717,21 @@ class TableEnvironmentTest {
assertThat(ResolvedSchema.of(Column.physical("database name",
DataTypes.STRING())))
.isEqualTo(tableResult5.getResolvedSchema)
assertThat(CollectionUtil.iteratorToList(tableResult5.collect).toArray())
- .isEqualTo(util.Arrays.asList(Row.of("db1"), Row.of("db2")).toArray())
+ .containsExactly(util.Arrays.asList(Row.of("db1"),
Row.of("db2")).toArray())
val tableResult6 = tableEnv.executeSql("SHOW DATABASES LIKE '_re%'")
assertThat(tableResult6.getResultKind).isEqualTo(ResultKind.SUCCESS_WITH_CONTENT)
assertThat(ResolvedSchema.of(Column.physical("database name",
DataTypes.STRING())))
.isEqualTo(tableResult6.getResolvedSchema)
assertThat(CollectionUtil.iteratorToList(tableResult6.collect).toArray())
- .isEqualTo(util.Arrays.asList(Row.of("pre_db3")).toArray())
+ .containsExactly(util.Arrays.asList(Row.of("pre_db3")).toArray())
val tableResult7 = tableEnv.executeSql("SHOW DATABASES NOT LIKE '_re%'")
assertThat(tableResult7.getResultKind).isEqualTo(ResultKind.SUCCESS_WITH_CONTENT)
assertThat(ResolvedSchema.of(Column.physical("database name",
DataTypes.STRING())))
.isEqualTo(tableResult7.getResolvedSchema)
assertThat(CollectionUtil.iteratorToList(tableResult7.collect).toArray())
- .isEqualTo(util.Arrays.asList(
+ .containsExactly(util.Arrays.asList(
Review Comment:
no need for `Arrays.asList`, you can use a vararg here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
