PatrickRen commented on code in PR #19366:
URL: https://github.com/apache/flink/pull/19366#discussion_r845833503
##########
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/enumerator/subscriber/KafkaSubscriber.java:
##########
@@ -38,9 +38,11 @@
* </ol>
*
* <p>The KafkaSubscriber provides a unified interface for the Kafka source to
support all these
- * three types of subscribing mode.
+ * three types of subscribing mode. {@link
+ * org.apache.flink.connector.kafka.source.enumerator.KafkaSourceEnumerator}
only supports adding
+ * new splits and not removing splits in split discovery.
*/
-@Internal
+@PublicEvolving
Review Comment:
IMHO it's reasonable to make `KafkaSubscriber` public. As we are exposing
new APIs to users, what about starting a discussion in dev and user mailing
list?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
