gaoyunhaii commented on code in PR #19395:
URL: https://github.com/apache/flink/pull/19395#discussion_r845984674
##########
flink-yarn/src/main/java/org/apache/flink/yarn/YarnTaskExecutorRunner.java:
##########
@@ -103,6 +103,11 @@ static void setupAndModifyConfiguration(
BootstrapTools.updateTmpDirectoriesInConfiguration(configuration,
localDirs);
setupConfigurationFromVariables(configuration, currDir, variables);
+
+ configuration
Review Comment:
This should be unnecessary if we have already removed the configuration in
the client side~?
##########
flink-yarn/src/main/java/org/apache/flink/yarn/YarnTaskExecutorRunner.java:
##########
@@ -103,6 +103,11 @@ static void setupAndModifyConfiguration(
BootstrapTools.updateTmpDirectoriesInConfiguration(configuration,
localDirs);
setupConfigurationFromVariables(configuration, currDir, variables);
+
+ configuration
Review Comment:
This should be unnecessary if we have already removed the configuration in
the client side~?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
