Github user wangzhijiang999 commented on the issue:
https://github.com/apache/flink/pull/2400
Hi @mxm , I pushed some modifications based on your comments, including:
1. Make var as final
2. Implement TaskExecutorConfiguration class in java instead of
TaskManagerConfiguration in scala, the NetworkEnvironmentConfiguration should
also be rewrote by java, but it will cause import mistake in
NetworkEnvironment, so retain the current implementation.
3. Replace scala tuple2<hostname, port> by InetAddress, and the scala
tuple4 by org.apache.flink.api.java.tuple.Tuple4
4. Remove throws in checkConfigParameter method
5. There are two public static methods
"selectNetworkInterfaceAndRunTaskManager" and
"startTaskManagerComponentsAndActor" that can be invoked by outside world. For
startTaskManagerComponentsAndActor method, the parameters should pass
"RPCService" and "HighAvailabilityServices" for constructing "TaskExecutor"
directly. For "startTaskManagerComponentsAndActor" method, we will generate the
default "RPCService" and "HighAvailabilityServices" or based on configuration.
6. Fix the missing ResourceID parameter description.
Thank you for further suggestions!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
