[ 
https://issues.apache.org/jira/browse/FLINK-27137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17519674#comment-17519674
 ] 

Arvid Heise commented on FLINK-27137:
-------------------------------------

Hi [~gyfora], sorry if you perceived my message as unfriendly that was not my 
intention. :(

I just expect a ticket that basically reverts a ticket that went through duly 
process to be more descriptive so that everyone can understand the issue and 
discuss. The information in the ticket description is still lacking in that 
regard. 

You are also completely dismissing the valid use case of users not depending on 
Java 8, simply bumping Kafka dependency to 3 and use the new functionality. So 
please go for an approach that makes both possible.

I'd also raise the possibility that you simply implement a limited 
{{AdminClient}} on your end as well or else you may run into issues with other 
Java-based frameworks, such as Spark, that may or may not also use the 
{{AdminClient}}. Expecting certain frameworks to use one part of Public API of 
a client jar and not another is a non-obvious requirement. For context, you 
can't run Pulsar without its {{AdminClient}}, so don't read too much into the 
name. Lastly, even Redpanda is providing that API to be a full drop-in 
replacement.

In general, I'd deem your approach to security as non-standard, so please make 
sure to not disable the standard cases by simply reverting. 

> Remove usage of AdminClient from KafkaSource logic
> --------------------------------------------------
>
>                 Key: FLINK-27137
>                 URL: https://issues.apache.org/jira/browse/FLINK-27137
>             Project: Flink
>          Issue Type: Improvement
>          Components: Connectors / Kafka
>    Affects Versions: 1.15.0, 1.14.4
>            Reporter: Gyula Fora
>            Priority: Major
>
> Parts of the KafkaSource logic (specifically the KafkaSourceEnumerator) uses 
> the Kafka AdminClient instead of the KafkaConsumer.
> It seems that the KafkaConsumer already provides all the necessary 
> information that the enumerator needs so there is no reason for introducing 
> the AdminClient.
> In some environments using the AdminClient can be problematic even if we are 
> not using certaing features.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to