[
https://issues.apache.org/jira/browse/FLINK-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15434388#comment-15434388
]
ASF GitHub Bot commented on FLINK-4453:
---------------------------------------
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2411
Thanks for the quick fix, @wuchong!
The change looks good, but I just realized that the Java code might be on
purpose in the Scala tab. It shows the interface of the `WindowFunction` which
is defined in Java and the same interface is used by the Scala API. So not sure
if we should translate the code to Scala because a Scala version of the
interface does not exist.
Maybe adding a comment that the Scala API uses Java interfaces is better?
> Scala code example in Window documentation shows Java
> -----------------------------------------------------
>
> Key: FLINK-4453
> URL: https://issues.apache.org/jira/browse/FLINK-4453
> Project: Flink
> Issue Type: Bug
> Components: Documentation
> Affects Versions: 1.2.0
> Reporter: Fabian Hueske
> Assignee: Jark Wu
> Priority: Trivial
>
> The first code example in the section "WindowFunction - The Generic Case" of
> the window documentation of the 1.2 SNAPSHOT
> (https://ci.apache.org/projects/flink/flink-docs-master/apis/streaming/windows.html#windowfunction---the-generic-case)
> shows Java code in the Scala tab.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
