XComp commented on code in PR #19427:
URL: https://github.com/apache/flink/pull/19427#discussion_r848349135
##########
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java:
##########
@@ -420,7 +420,7 @@ public void
testCancellationOfCanceledTerminalDoesNotThrowException() throws Exc
.build())));
// wait for job to finish
- dispatcherGateway.requestJobResult(jobId, TIMEOUT).get();
+ dispatcher.getJobTerminationFuture(jobId, TIMEOUT).get();
Review Comment:
I'm not sure about that. `Dispatcher#requestJobResult` is not necessarily
triggered before the job submission goes through in
[DispatcherTest:969](https://github.com/apache/flink/blob/1cb80e6d1ed0331ba662e481705b6b716f29b26a/flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java#L969).
Therefore, we might endup in the code branch of `requestJobResult` again where
the `Dispatcher` accesses the `ExecutionGraphInfoStore`.
I was thinking about something like this:
https://gist.github.com/XComp/6f082c15ce10ceae3f743f84b6bc6903
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
