[ 
https://issues.apache.org/jira/browse/FLINK-4471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15434635#comment-15434635
 ] 

ASF GitHub Bot commented on FLINK-4471:
---------------------------------------

GitHub user gyfora opened a pull request:

    https://github.com/apache/flink/pull/2413

    [FLINK-4471] Use user code classloader to deserialize state descriptor in 
Rocks backend

    Thanks for contributing to Apache Flink. Before you open your pull request, 
please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your 
pull request. For more information and/or questions please refer to the [How To 
Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful 
description of your changes.
    
    - [ ] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira 
title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the 
JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [ ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis 
build has passed
    
    …r in RocksDb backend

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gyfora/flink FLINK-4471

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2413.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2413
    
----
commit b046c768d9b2c79297ae37c5dac2aa66a94ebc37
Author: Gyula Fora <[email protected]>
Date:   2016-08-24T10:02:51Z

    [FLINK-4471] Use user code classloader to deserialize state descriptor in 
RocksDb backend

----


> Rocks backend fully async snapshot restore fails with custom serializers
> ------------------------------------------------------------------------
>
>                 Key: FLINK-4471
>                 URL: https://issues.apache.org/jira/browse/FLINK-4471
>             Project: Flink
>          Issue Type: Bug
>          Components: State Backends, Checkpointing, Streaming
>    Affects Versions: 1.1.0
>            Reporter: Gyula Fora
>            Assignee: Gyula Fora
>            Priority: Critical
>
> The StateDescriptor is not deserialized with the usercode classloader. This 
> makes restore fail with NoClassDefFound error if the user uses custom type 
> serializers:
> https://github.com/apache/flink/blob/master/flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackend.java#L583



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to