JingsongLi commented on code in PR #87:
URL: https://github.com/apache/flink-table-store/pull/87#discussion_r849441212
##########
flink-table-store-core/src/test/java/org/apache/flink/table/store/file/predicate/PredicateTest.java:
##########
@@ -315,6 +321,20 @@ public void testOr() {
.isEqualTo(false);
}
+ @MethodSource("provideLikeExpressions")
+ @ParameterizedTest
+ public void testStartsWith(
+ Tuple3<
Review Comment:
Use multiple arguments? The readability of `Tuple3` is not good, Just like:
```
@ParameterizedTest
@MethodSource("provideStringsForIsBlank")
void isBlank_ShouldReturnTrueForNullOrBlankStrings(String input, boolean
expected) {
assertEquals(expected, Strings.isBlank(input));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
