gaborgsomogyi commented on code in PR #19372:
URL: https://github.com/apache/flink/pull/19372#discussion_r849582652
##########
flink-runtime/src/main/java/org/apache/flink/runtime/security/token/KerberosDelegationTokenManager.java:
##########
@@ -45,10 +56,28 @@ public class KerberosDelegationTokenManager implements
DelegationTokenManager {
private final Configuration configuration;
+ private final SecurityConfiguration securityConfiguration;
+
+ private final KerberosRenewalPossibleProvider
kerberosRenewalPossibleProvider;
+
@VisibleForTesting final Map<String, DelegationTokenProvider>
delegationTokenProviders;
- public KerberosDelegationTokenManager(Configuration configuration) {
+ private final ScheduledExecutor scheduledExecutor;
+
+ private final ExecutorService executorService;
+
+ private ScheduledFuture<?> tgtRenewalFuture;
+
+ public KerberosDelegationTokenManager(
+ Configuration configuration,
+ @Nullable ScheduledExecutor scheduledExecutor,
+ @Nullable ExecutorService executorService) {
Review Comment:
There are basically 2 use-cases for DT creation:
* Single obtain
* DTM start where auto obtain + propagation happens in a re-occuring way
These 2 use-cases require different internals. So all in all both belong to
the interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
