bgeng777 commented on code in PR #165:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/165#discussion_r850207724
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultValidator.java:
##########
@@ -261,7 +261,7 @@ private Optional<String> validateSpecChange(FlinkDeployment
deployment) {
&& deployment.getStatus().getJobManagerDeploymentStatus()
!= JobManagerDeploymentStatus.MISSING
&&
ReconciliationUtils.isUpgradeModeChangedToLastStateAndHADisabledPreviously(
- deployment)) {
+ deployment, new Configuration())) {
Review Comment:
A concern for the refactor:
I do agree that introducing the defaultConfig in this validation as it is
possible that some users may modify the default filnk-conf.yaml(e.g. adding HA
config). But I am a little concerned that should we pass en empty config or
using `FlinkUtils.loadConfiguration(EnvUtils.get(EnvUtils.ENV_FLINK_CONF_DIR))`
? So the Validator can work correctly if users do not specify HA config in Spec
but add them in flink-conf.yaml.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
