[ 
https://issues.apache.org/jira/browse/FLINK-27249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522248#comment-17522248
 ] 

Xin Hao commented on FLINK-27249:
---------------------------------

Agreed with `everything in the Spec is "desired". `

But the `state/status` in the K8s's objects is standing for `current condition` 
in most scenarios.

 

I'm not sure whether there are more desired states but not running, if so, I 
think it should be called `mode` or split the state into multi boolean flags 
such as `suspend: false`?

 

Anyway, this is not something big, I'll keep this ticket open for 1 or 2 days 
and will close it if no more discussions.

 

> Change the state field in the FlinkSessionJob.Spec.Job into desiredState
> ------------------------------------------------------------------------
>
>                 Key: FLINK-27249
>                 URL: https://issues.apache.org/jira/browse/FLINK-27249
>             Project: Flink
>          Issue Type: Improvement
>          Components: Kubernetes Operator
>            Reporter: Xin Hao
>            Priority: Minor
>
> {code:java}
> /** Desired state for the job. */
> private JobState state = JobState.RUNNING; {code}
> It will confuse the users when getting info from the K8s. Such as
> {code:java}
> spec:
>   clusterId: session-cluster-test
>   job:
>     jarURI: file:///flink-examples-streaming_2.12-1.14.4-TopSpeedWindowing.jar
>     state: running
>     ...
> status:
>   jobStatus:
>     jobId: 42bf3c6f2ac1d909b054b75c20c30afe
>     state: RUNNING
>     ...{code}
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to