gyfora commented on PR #165: URL: https://github.com/apache/flink-kubernetes-operator/pull/165#issuecomment-1101153883
> > @wangyang0918 I think for the suspend to work, I need to fix 2 things basically: > > > > 1. If the user suspends a job, the spec should be automatically marked as `lastStableSpec` > > 2. If an upgrade after a suspend fails, we should roll back to the suspended state (simply stop the job) > > > > Will work on this over the weekend > > It seems that the current implementation is not consistent with fix 2. But I lean to the current behavior that we should not roll back to suspended state. This will help users to quickly figure out the incorrect fields updates. Yes, I changed my mind along the logic that you also highlighted. If the previous state was suspended, it is better to not roll back to allow users to find errors isntead -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
