wangyang0918 commented on code in PR #171:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/171#discussion_r852551483
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java:
##########
@@ -225,7 +225,9 @@ public Optional<String> cancelJob(
public void stopSessionCluster(
FlinkDeployment deployment, Configuration conf, boolean
deleteHaData) {
FlinkUtils.deleteCluster(deployment, kubernetesClient, deleteHaData);
- FlinkUtils.waitForClusterShutdown(kubernetesClient, conf);
+ if (!deleteHaData) {
Review Comment:
Could we simply remove the
`FlinkUtils.waitForClusterShutdown(kubernetesClient, conf)` here and call it
directly in the `SessionReconciler#upgradeSessionCluster`?
Further more, we may do not need the `FlinkService#stopSessionCluster` and
use `FlinkUtils.deleteCluster` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
