afedulov commented on code in PR #19228:
URL: https://github.com/apache/flink/pull/19228#discussion_r853522448
##########
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java:
##########
@@ -545,23 +545,29 @@ private void stopTaskExecutorServices() throws Exception {
@Override
public CompletableFuture<TaskThreadInfoResponse> requestThreadInfoSamples(
- final ExecutionAttemptID taskExecutionAttemptId,
+ final Set<ExecutionAttemptID> taskExecutionAttemptIds,
Review Comment:
I was not sure if there could be an edge case of getting the same
ExecutionAttemptID multiple times and wanted to avoid "double" representation
in the FlameGraphs. But I agree, this probably should never happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
