wangyang0918 commented on code in PR #173:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/173#discussion_r853808587
##########
.github/workflows/ci.yml:
##########
@@ -73,7 +73,7 @@ jobs:
- name: Tests in flink-kubernetes-operator
run: |
cd flink-kubernetes-operator
- mvn integration-test -Dit.skip=false
+ mvn verify -Dit.skip=false
cd ..
- name: Tests in flink-kubernetes-webhook
Review Comment:
Could we also use the `mvn verify` in "Tests in flink-kubernetes-webhook"
even though we do not have ITCase now?
##########
.gitignore:
##########
@@ -35,3 +35,4 @@ buildNumber.properties
.idea
*.iml
+*.DS_Store
Review Comment:
nit: Keep the empty line at end of file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
