XComp commented on code in PR #19444:
URL: https://github.com/apache/flink/pull/19444#discussion_r853919505
##########
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/ReporterSetup.java:
##########
@@ -462,6 +462,15 @@ private static Optional<MetricReporter> loadViaReflection(
alternativeFactoryClassName);
return loadViaFactory(
alternativeFactoryClassName, reporterName, reporterConfig,
reporterFactories);
+ } else {
+ LOG.warn(
Review Comment:
This warning won't be printed if user still used
`MetricOptions#REPORTER_CLASS` but has a matching factory class that can be
used for `loadViaFactory`. I think we should move this log message up in the
call stack and add it to `loadReporter` instead...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
