zoltar9264 commented on code in PR #19441:
URL: https://github.com/apache/flink/pull/19441#discussion_r853922622
##########
flink-dstl/flink-dstl-dfs/src/test/java/org/apache/flink/changelog/fs/ChangelogStorageMetricsTest.java:
##########
@@ -295,6 +349,39 @@ public void close() {
}
}
+ private static class FixedLatencyUploader implements StateChangeUploader {
+ private final long latency;
+
+ public FixedLatencyUploader(long latency) {
+ this.latency = latency;
+ }
+
+ @Override
+ public UploadTasksResult upload(Collection<UploadTask> tasks) throws
IOException {
+ Map<UploadTask, Map<StateChangeSet, Long>> map = new HashMap<>();
+
+ try {
+ TimeUnit.MILLISECONDS.sleep(latency);
Review Comment:
Thanks for your nice suggestion @rkhachatryan .
First, yes, testTotalAttemptsPerUpload completes the first attempt.
Second, I agree with keep these tests separate.
Third, the implementation of testTotalAttemptsPerUpload, I think you are
right.
And I think we can implement waiting in 1st attempt for the others in
MaxAttemptUploader. What do you think about ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
