afedulov commented on code in PR #19405: URL: https://github.com/apache/flink/pull/19405#discussion_r854203781
########## flink-end-to-end-tests/flink-end-to-end-tests-elasticsearch-common/src/main/java/org/apache/flink/streaming/tests/ElasticsearchDataReader.java: ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.streaming.tests; + +import org.apache.flink.connector.testframe.external.ExternalSystemDataReader; + +import java.time.Duration; +import java.util.List; + +import static org.apache.flink.util.Preconditions.checkNotNull; + +/** Elasticsearch data reader. */ +public class ElasticsearchDataReader + implements ExternalSystemDataReader<KeyValue<Integer, String>> { + private final ElasticsearchClient client; + private final String indexName; + private final int pageLength; + private int from; + + public ElasticsearchDataReader(ElasticsearchClient client, String indexName, int pageLength) { + this.client = checkNotNull(client); + this.indexName = checkNotNull(indexName); + this.pageLength = pageLength; + } + + @Override + public List<KeyValue<Integer, String>> poll(Duration timeout) { + client.refreshIndex(indexName); + // TODO: Tests are flaky without this small delay. Review Comment: I will try, but I suspect that the issue manifests itself between the time when the writes are done from the Flink side and the test immediately starts the reader, which somehow still does not see the written data, even despite an active blocking index refresh. As the policy is related to writes, not reads, I do not expect it to change much. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
