Vancior commented on code in PR #19453:
URL: https://github.com/apache/flink/pull/19453#discussion_r854719409
##########
flink-python/src/main/java/org/apache/flink/streaming/api/runners/python/beam/BeamPythonFunctionRunner.java:
##########
@@ -190,7 +194,8 @@ public BeamPythonFunctionRunner(
MemoryManager memoryManager,
double managedMemoryFraction,
FlinkFnApi.CoderInfoDescriptor inputCoderDescriptor,
- FlinkFnApi.CoderInfoDescriptor outputCoderDescriptor) {
+ FlinkFnApi.CoderInfoDescriptor outputCoderDescriptor,
+ @Nullable Map<String, FlinkFnApi.CoderInfoDescriptor>
sideOutputCoderDescriptors) {
Review Comment:
Table operators don't have side outputs, so I assume it's reasonable to use
`null` for `sideOutputCoderDescriptors` in `BeamTablePythonFunctionRunner`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
