wangyang0918 commented on code in PR #168:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/168#discussion_r854741196
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java:
##########
@@ -204,12 +209,14 @@ private JarRunResponseBody runJar(
}
}
- private JarUploadResponseBody uploadJar(FlinkSessionJob sessionJob,
Configuration conf)
+ private JarUploadResponseBody uploadJar(
+ FlinkSessionJob sessionJob, FlinkDeployment sessionCluster,
Configuration conf)
throws Exception {
- Path path =
jarResolver.resolve(sessionJob.getSpec().getJob().getJarURI());
+ String targetDir = artifactManager.generateJarDir(sessionCluster,
sessionJob);
+ File jarFile =
artifactManager.fetch(sessionJob.getSpec().getJob().getJarURI(), targetDir);
Review Comment:
Let's keep the current behavior and do some improvements later if necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
