weibozhao commented on code in PR #83:
URL: https://github.com/apache/flink-ml/pull/83#discussion_r854906971
##########
flink-ml-lib/src/main/java/org/apache/flink/ml/classification/logisticregression/LogisticRegression.java:
##########
@@ -391,7 +391,8 @@ public void onIterationTerminated(Context context,
Collector<double[]> collector
feedbackBufferState.clear();
if (getRuntimeContext().getIndexOfThisSubtask() == 0) {
updateModel();
- context.output(modelDataOutputTag, new
LogisticRegressionModelData(coefficient));
+ context.output(
+ modelDataOutputTag, new
LogisticRegressionModelData(coefficient, 0L));
Review Comment:
This is not conflict with barrierModelData. This just add a version for
every model produced by online algo or offline algo. then, the offline and
online algo can share the same model data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
