yunfengzhou-hub commented on code in PR #87:
URL: https://github.com/apache/flink-ml/pull/87#discussion_r857087337
##########
flink-ml-benchmark/src/main/java/org/apache/flink/ml/benchmark/BenchmarkResult.java:
##########
@@ -18,13 +18,25 @@
package org.apache.flink.ml.benchmark;
+import org.apache.flink.ml.api.Stage;
+import org.apache.flink.ml.benchmark.datagenerator.DataGenerator;
+import org.apache.flink.ml.benchmark.datagenerator.InputDataGenerator;
import org.apache.flink.util.Preconditions;
/** The result of executing a benchmark. */
public class BenchmarkResult {
/** The benchmark name. */
public final String name;
+ /** The stage to execute benchmark on. */
+ public final Stage<?> stage;
Review Comment:
I added a `toMap` function to `BenchmarkResult` and a `ExceptionToMap`
static method to `BenchmarkUtils`. Please see if this solution is good enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
