Myasuka commented on code in PR #19448:
URL: https://github.com/apache/flink/pull/19448#discussion_r857491738
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultExecutionGraphFactory.java:
##########
@@ -203,10 +204,15 @@ private void tryRestoreExecutionGraphFromSavepoint(
final CheckpointCoordinator checkpointCoordinator =
executionGraphToRestore.getCheckpointCoordinator();
if (checkpointCoordinator != null) {
+ Optional<String> stateBackendName =
executionGraphToRestore.getStateBackendName();
+ boolean changelogEnabled =
+ stateBackendName.isPresent()
+ &&
"ChangelogStateBackend".equals(stateBackendName.get());
Review Comment:
Though we cannot guarantee that the `flink-conf` same both on JM and TM
side, however, this usually does not happen in production environment. What's
more, unmatched configurations would also bring other problems except this.
I think we don't need to focus on this cocern case, we should focus on the
general prons and cons of which each solution would make.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
