reswqa commented on code in PR #19560:
URL: https://github.com/apache/flink/pull/19560#discussion_r858229604
##########
flink-kubernetes/src/test/java/org/apache/flink/kubernetes/KubernetesExtension.java:
##########
@@ -44,14 +48,14 @@ public class KubernetesResource extends ExternalResource {
public static void checkEnv() {
final String kubeConfigEnv = System.getenv("ITCASE_KUBECONFIG");
- Assume.assumeTrue(
- "ITCASE_KUBECONFIG environment is not set.",
- !StringUtils.isNullOrWhitespaceOnly(kubeConfigEnv));
+ assertThat(StringUtils.isNullOrWhitespaceOnly(kubeConfigEnv))
Review Comment:
Let me confirm that this line of code should reverts to the state before
modification, so that the test will be skipped instead of failed in the CI
environment without k8s, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
