tsreaper commented on code in PR #97:
URL: https://github.com/apache/flink-table-store/pull/97#discussion_r858505932


##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/mergetree/MergeTreeWriter.java:
##########
@@ -111,7 +114,10 @@ public void write(ValueKind valueKind, RowData key, 
RowData value) throws Except
 
     private void flush() throws Exception {
         if (memTable.size() > 0) {
-            finishCompaction();
+            if (levels.numberOfSortedRuns() > numSortedRunStopTrigger) {

Review Comment:
   Currently number of sorted runs is limited by `compaction due to file num`. 
If we add async compaction it is very likely that number of sorted runs exceed 
the limit. What to do under this scenario?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to