Myasuka commented on code in PR #19550:
URL: https://github.com/apache/flink/pull/19550#discussion_r859349613
##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FileStateHandle.java:
##########
@@ -73,6 +74,11 @@ public Optional<byte[]> asBytesIfInMemory() {
return Optional.empty();
}
+ @Override
+ public PhysicalStateHandleID getStreamStateHandleID() {
+ return new PhysicalStateHandleID(filePath.toUri().toString());
Review Comment:
In general, when we add a new field in a Serializable class, we need to
consider the NPE when deserializing previous existing objects. That's why I
suggest to make it `null` by default. I checked the place to deserialize
`FileStateHandle`, it should be fine here to initialize it directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
