[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15436834#comment-15436834
]
ASF GitHub Bot commented on FLINK-4389:
---------------------------------------
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2363
I've updated and rebased the PR.
The scope information is now stored in a `QueryScopeInfo` inside the
`MetricGroups`, for which sub-classes like `TaskQueryScopeInfo` exist. They
contain fields for specific values, like the job ID, and the remaining scope
not covered by these fields.
Metrics, or rather their scope, name and value(s), are now serialized with
a new `MetricDumpSerializer` to a byte[] using a `Data-/ByteArrayOutputStream`.
On the other end we have the `MetricDumpDeserializer` which deserializes
the metrics to a `List<MetricDump>`. A `MetricDump`is a container for the
metric value, it's name the `QueryScopeInfo`. There are sub-classes for each
metric type, like `CounterDump`.
Neither the `MetricQueryService` nor `MetricFetcher` know anything about
the serialized format, just that it's a byte array.
There is no encoding for field orderings but tests that verify that the
fields are assigned correctly. If a developer were to change the order of
fields a test would fail, and the only way for this to make it into master
would be if a) the test is simply changed to give a green light and b) it isn't
noticed in the review, at which point all bets are of anyway. So i decided to
keep it a bit simpler.
The `MetricStore#addMetric()` method has now become a bit smarter in
regards to handling ´Histograms`. With all values being contained in a
`HistogramDump` we now only have to analyze the scope once.
> Expose metrics to Webfrontend
> -----------------------------
>
> Key: FLINK-4389
> URL: https://issues.apache.org/jira/browse/FLINK-4389
> Project: Flink
> Issue Type: Sub-task
> Components: Metrics, Webfrontend
> Affects Versions: 1.1.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Fix For: pre-apache
>
>
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-7%3A+Expose+metrics+to+WebInterface
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
