zlzhang0122 commented on code in PR #8751:
URL: https://github.com/apache/flink/pull/8751#discussion_r860405882
##########
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksIncrementalSnapshotStrategy.java:
##########
@@ -177,6 +187,11 @@ public void notifyCheckpointComplete(long
completedCheckpointId) {
materializedSstFiles.keySet().removeIf(checkpointId -> checkpointId <
completedCheckpointId);
lastCompletedCheckpointId =
completedCheckpointId;
}
+
+ // We need to close the file for current completed
checkpoint.
+ if (checkpointStreamFactory instanceof
FsSegmentCheckpointStreamFactory) {
Review Comment:
I think maybe we also need to close the file for current aborted checkpoint
too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
