rkhachatryan commented on code in PR #19598:
URL: https://github.com/apache/flink/pull/19598#discussion_r860732625
##########
flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogKeyedStateBackend.java:
##########
@@ -694,6 +705,10 @@ public KeyedStateBackend<K>
getDelegatedKeyedStateBackend(boolean recursive) {
return keyedStateBackend.getDelegatedKeyedStateBackend(recursive);
}
+ public ChangelogMetricGroup getMetrics() {
+ return metrics;
+ }
Review Comment:
I think it makes sense to split `ChangelogMetricGroup` into two: one for
backend, and one for materializer.
Furthermore, after size moving reporting to `buildSnapshotResult` (as per
comment
[below](https://github.com/apache/flink/pull/19598#discussion_r860735113)),
the backend would only need report these sizes; and Materializer - events,
such as started/completed/failed materialization.
That would eliminate the dependency and syncrhonization issues, and make the
responsibilities of metric group classes more clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
