zentol commented on code in PR #19590:
URL: https://github.com/apache/flink/pull/19590#discussion_r862825359
##########
flink-formats/flink-json/src/test/java/org/apache/flink/formats/json/ogg/OggJsonSerDeSchemaTest.java:
##########
@@ -119,18 +116,19 @@ public void testDeserializationWithMetadata(String
resourceFile) throws Exceptio
final SimpleCollector collector = new SimpleCollector();
deserializationSchema.deserialize(firstLine.getBytes(StandardCharsets.UTF_8),
collector);
- assertEquals(1, collector.list.size());
+ assertThat(collector.list).hasSize(1);
Consumer<RowData> consumer =
row -> {
- assertEquals(101, row.getInt(0));
- assertEquals("scooter", row.getString(1).toString());
- assertEquals("Small 2-wheel scooter",
row.getString(2).toString());
- assertEquals(3.140000104904175, row.getFloat(3), 1e-15);
- assertEquals("OGG.TBL_TEST", row.getString(4).toString());
- assertEquals("id",
row.getArray(5).getString(0).toString());
- assertEquals(1589377175766L, row.getTimestamp(6,
6).getMillisecond());
- assertEquals(1589384406000L, row.getTimestamp(7,
6).getMillisecond());
+ assertThat(row.getInt(0)).isEqualTo(101);
+
assertThat(row.getString(1).toString()).isEqualTo("scooter");
+ assertThat(row.getString(2).toString()).isEqualTo("Small
2-wheel scooter");
+ assertThat(row.getFloat(3))
+ .isCloseTo(3.140000104904175f,
Percentage.withPercentage(1e-15));
+
assertThat(row.getString(4).toString()).isEqualTo("OGG.TBL_TEST");
+
assertThat(row.getArray(5).getString(0).toString()).isEqualTo("id");
+ assertThat(row.getTimestamp(6,
6).getMillisecond()).isEqualTo(1589377175766L);
+ assertThat(row.getTimestamp(7,
6).getMillisecond()).isEqualTo(1589384406000L);
};
Review Comment:
```suggestion
});
```
##########
flink-formats/flink-json/src/test/java/org/apache/flink/formats/json/maxwell/MaxwellJsonSerDerTest.java:
##########
@@ -85,23 +83,23 @@ public void testDeserializationWithMetadata() throws
Exception {
TimestampFormat.ISO_8601);
final SimpleCollector collector = new SimpleCollector();
deserializationSchema.deserialize(firstLine.getBytes(StandardCharsets.UTF_8),
collector);
- assertEquals(1, collector.list.size());
+ assertThat(collector.list).hasSize(1);
Consumer<RowData> consumer =
row -> {
- assertThat(row.getInt(0), equalTo(101));
- assertThat(row.getString(1).toString(),
equalTo("scooter"));
- assertThat(row.getString(2).toString(), equalTo("Small
2-wheel scooter"));
- assertThat(row.getFloat(3), equalTo(3.14f));
- assertThat(row.getString(4).toString(), equalTo("test"));
- assertThat(row.getString(5).toString(),
equalTo("product"));
- assertThat(row.getArray(6).getString(0).toString(),
equalTo("id"));
- assertThat(row.getTimestamp(7, 3).getMillisecond(),
equalTo(1596684883000L));
+ assertThat(row.getInt(0)).isEqualTo(101);
+
assertThat(row.getString(1).toString()).isEqualTo("scooter");
+ assertThat(row.getString(2).toString()).isEqualTo("Small
2-wheel scooter");
+ assertThat(row.getFloat(3)).isEqualTo(3.14f);
+ assertThat(row.getString(4).toString()).isEqualTo("test");
+
assertThat(row.getString(5).toString()).isEqualTo("product");
+
assertThat(row.getArray(6).getString(0).toString()).isEqualTo("id");
+ assertThat(row.getTimestamp(7,
3).getMillisecond()).isEqualTo(1596684883000L);
};
Review Comment:
```suggestion
});
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
