gyfora commented on code in PR #193:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/193#discussion_r865823862
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigBuilder.java:
##########
@@ -216,6 +217,9 @@ protected FlinkConfigBuilder applyJobOrSessionSpec() throws
URISyntaxException {
effectiveConfig.set(
CoreOptions.DEFAULT_PARALLELISM,
spec.getJob().getParallelism());
}
+ if (spec.getJob().isAllowNonRestoredState()) {
+
effectiveConfig.set(SavepointConfigOptions.SAVEPOINT_IGNORE_UNCLAIMED_STATE,
true);
Review Comment:
I think we could make the `allowNonRestoredState` Boolean instead of boolean
and set it into the config regardless of the value if it's not null.
With the current logic if the user defines true in the flinkConfiguration
and sets it to false in the jobspec we would not use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
