gyfora commented on code in PR #195:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/195#discussion_r865863929
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/deployment/AbstractDeploymentObserver.java:
##########
@@ -211,6 +219,22 @@ protected boolean isSuspendedJob(FlinkDeployment
deployment) {
&& lastReconciledSpec.getJob().getState() ==
JobState.SUSPENDED;
}
+ private void onMissingDeployment(FlinkDeployment deployment) {
Review Comment:
On-going upgrade would never trigger this , when the job is in suspended
state with missing deployment we won't try to observe it.
Even if we trigger there is a problem we should never clean up the
deployment, as the user probably needs to manually recover the job. Cleanup is
reserved for deletions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
