RocMarshal commented on code in PR #18983:
URL: https://github.com/apache/flink/pull/18983#discussion_r865948929
##########
flink-yarn/src/test/java/org/apache/flink/yarn/YarnResourceManagerDriverTest.java:
##########
@@ -293,9 +304,22 @@ public void testTerminationWaitsOnContainerStopError()
throws Exception {
getDriver().terminate();
});
- assertThat(
- driverHasTerminatedFuture,
-
FlinkMatchers.willNotComplete(Duration.ofMillis(20L)));
+ assertThat(driverHasTerminatedFuture)
+ .satisfies(
+ new
Condition<CompletableFuture<?>>() {
Review Comment:
Done.
##########
flink-yarn/src/test/java/org/apache/flink/yarn/YarnResourceManagerDriverTest.java:
##########
@@ -175,15 +175,13 @@ public void testShutdownRequestCausesFatalError() throws
Exception {
Throwable throwable =
throwableCompletableFuture.get(TIMEOUT_SEC, TimeUnit.SECONDS);
assertThat(
- ExceptionUtils.findThrowable(
- throwable,
ResourceManagerException.class)
- .isPresent(),
- is(true));
+ ExceptionUtils.findThrowable(
+ throwable,
ResourceManagerException.class))
+ .isPresent();
assertThat(
- ExceptionUtils.findThrowableWithMessage(
- throwable,
ERROR_MESSAGE_ON_SHUTDOWN_REQUEST)
- .isPresent(),
- is(true));
+
ExceptionUtils.findThrowableWithMessage(
+ throwable,
ERROR_MESSAGE_ON_SHUTDOWN_REQUEST))
+ .isPresent();
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
