gyfora commented on code in PR #194:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/194#discussion_r866026252
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/controller/FlinkSessionJobController.java:
##########
@@ -114,7 +119,7 @@ public UpdateControl<FlinkSessionJob> reconcile(
} catch (Exception e) {
throw new ReconciliationException(e);
}
-
+ metricManager.onUpdate(flinkSessionJob);
Review Comment:
is this call necessary? The onUpdate at the end of reconcile should take
care of it I believe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
