Aitozi commented on PR #18762:
URL: https://github.com/apache/flink/pull/18762#issuecomment-1120353951

   @wangyang0918 Previously the `externalIP` will be try when the 
`loadBalancer` is null 
[code](https://github.com/apache/flink/blob/2727d0234cfd0c5431cf66df3a7951fbf37a28b2/flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java#L506).
 For the `LoadBalancerService` the behavior is not changed, But for the 
`NodePort` it will only look for the `nodeIp:nodePort` as endpoint now 
[code](https://github.com/apache/flink/blob/1e8f7f2cc27ae885399b7195d96b40c4c9158305/flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/services/NodePortService.java#L58)
 
   
   But In my test, the `status#loadBalancer` is not null for each service type, 
So the behavior of the NodePort will not change actually. The situation is a 
bit confused, it mainly caused by the previous implicit behavior I think.  
Please let me know if you have better suggestion. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to